Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix deprecation warnings in controllers from recent ros2_control variant changes. #1443

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Update set_value() usuage to fix warning in velocity_controllers

1044e67
Select commit
Loading
Failed to load commit list.
Draft

Draft: Fix deprecation warnings in controllers from recent ros2_control variant changes. #1443

Update set_value() usuage to fix warning in velocity_controllers
1044e67
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2024 in 1s

83.75% (-0.09%) compared to eaeefdf

View this Pull Request on Codecov

83.75% (-0.09%) compared to eaeefdf

Details

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.75%. Comparing base (eaeefdf) to head (1044e67).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...iff_drive_controller/src/diff_drive_controller.cpp 57.14% 7 Missing and 2 partials ⚠️
...ontrollers/src/joint_group_velocity_controller.cpp 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1443      +/-   ##
==========================================
- Coverage   83.83%   83.75%   -0.09%     
==========================================
  Files         122      122              
  Lines       11120    11139      +19     
  Branches      944      948       +4     
==========================================
+ Hits         9323     9329       +6     
- Misses       1489     1498       +9     
- Partials      308      312       +4
Files with missing lines Coverage Δ
...ontrollers/src/joint_group_velocity_controller.cpp 60.00% <0.00%> (-12.23%) ⬇️
...iff_drive_controller/src/diff_drive_controller.cpp 69.28% <57.14%> (-1.41%) ⬇️

... and 5 files with indirect coverage changes

View more details on Codecov