Update paths of GPL includes #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
the
backport-humble
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1487 +/- ##
==========================================
+ Coverage 83.86% 83.88% +0.02%
==========================================
Files 122 124 +2
Lines 11148 11177 +29
Branches 948 949 +1
==========================================
+ Hits 9349 9376 +27
- Misses 1486 1489 +3
+ Partials 313 312 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I was a bit puzzled that the binary builds succeeded, as I've just done the same changes on the ur_controllers repo. Is that still wanted that we have genParamLib in the ros2_controllers-not-released repos files? |
|
Good question, the changes are merged already. depends if we want to merge this PR soon to remove the warnings on the semi-binary build but keep the binary builds green? @bmagyar? |
github-actions
bot
requested review from
bijoua29,
destogl,
erickisos,
moriarty,
progtologist,
qiayuanl and
saikishor
saikishor
approved these changes
Jan 15, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 15, 2025
(cherry picked from commit bfe622c) # Conflicts: # ackermann_steering_controller/include/ackermann_steering_controller/ackermann_steering_controller.hpp # admittance_controller/include/admittance_controller/admittance_controller.hpp # admittance_controller/include/admittance_controller/admittance_rule.hpp # bicycle_steering_controller/include/bicycle_steering_controller/bicycle_steering_controller.hpp # diff_drive_controller/include/diff_drive_controller/diff_drive_controller.hpp # force_torque_sensor_broadcaster/include/force_torque_sensor_broadcaster/force_torque_sensor_broadcaster.hpp # forward_command_controller/include/forward_command_controller/forward_command_controller.hpp # forward_command_controller/include/forward_command_controller/multi_interface_forward_command_controller.hpp # gpio_controllers/include/gpio_controllers/gpio_command_controller.hpp # gripper_controllers/include/gripper_controllers/gripper_action_controller.hpp # imu_sensor_broadcaster/include/imu_sensor_broadcaster/imu_sensor_broadcaster.hpp # joint_state_broadcaster/include/joint_state_broadcaster/joint_state_broadcaster.hpp # joint_trajectory_controller/include/joint_trajectory_controller/joint_trajectory_controller.hpp # mecanum_drive_controller/include/mecanum_drive_controller/mecanum_drive_controller.hpp # parallel_gripper_controller/include/parallel_gripper_controller/parallel_gripper_action_controller.hpp # pid_controller/include/pid_controller/pid_controller.hpp # pose_broadcaster/include/pose_broadcaster/pose_broadcaster.hpp # range_sensor_broadcaster/include/range_sensor_broadcaster/range_sensor_broadcaster.hpp # steering_controllers_library/include/steering_controllers_library/steering_controllers_library.hpp # tricycle_controller/include/tricycle_controller/tricycle_controller.hpp # tricycle_steering_controller/include/tricycle_steering_controller/tricycle_steering_controller.hpp
christophfroehlich
added a commit
that referenced
this pull request
Jan 15, 2025
christophfroehlich
added a commit
that referenced
this pull request
Jan 16, 2025
Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs release 0.4.0
for reference, see PickNikRobotics/generate_parameter_library#213