Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty callbacks #1488

Merged
merged 3 commits into from
Jan 20, 2025

Merge branch 'master' into remove_empty_overrides

96eb8bc
Select commit
Loading
Failed to load commit list.
Merged

Remove empty callbacks #1488

Merge branch 'master' into remove_empty_overrides
96eb8bc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

83.90% (+0.02%) compared to bfe622c

View this Pull Request on Codecov

83.90% (+0.02%) compared to bfe622c

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.90%. Comparing base (bfe622c) to head (96eb8bc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1488      +/-   ##
==========================================
+ Coverage   83.88%   83.90%   +0.02%     
==========================================
  Files         124      124              
  Lines       11180    11171       -9     
  Branches      951      949       -2     
==========================================
- Hits         9378     9373       -5     
+ Misses       1488     1486       -2     
+ Partials      314      312       -2     
Files with missing lines Coverage Δ
...dmittance_controller/src/admittance_controller.cpp 74.71% <ø> (+0.55%) ⬆️
...jectory_controller/joint_trajectory_controller.hpp 100.00% <ø> (ø)
...ory_controller/src/joint_trajectory_controller.cpp 83.88% <ø> (-0.05%) ⬇️
pid_controller/src/pid_controller.cpp 68.42% <ø> (-0.28%) ⬇️

... and 2 files with indirect coverage changes