Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve antiwindup description #1502

Merged

Conversation

ViktorCVS
Copy link
Contributor

@ViktorCVS ViktorCVS commented Jan 21, 2025

Enhance the antiwindup description to accurately reflect its functionality in control_toolbox code.

control_toolbox/src/pid.cpp::170:173

 if (!gains.antiwindup_) {
    // Limit i_term so that the limit is meaningful in the output
    i_term = std::clamp(i_term, gains.i_min_, gains.i_max_);
  }

Enhance the antiwindup description to accurately reflect its
functionality in control_toolbox code.
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We can change that once again in case we have an upstream change to control_toolbox, see ros-controls/control_toolbox#276

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.20%. Comparing base (3d14b42) to head (f887517).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
+ Coverage   84.19%   84.20%   +0.01%     
==========================================
  Files         123      123              
  Lines       11322    11322              
  Branches      956      955       -1     
==========================================
+ Hits         9532     9534       +2     
+ Misses       1474     1473       -1     
+ Partials      316      315       -1     
Flag Coverage Δ
unittests 84.20% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@christophfroehlich christophfroehlich merged commit af572aa into ros-controls:master Jan 22, 2025
27 of 28 checks passed
mergify bot pushed a commit that referenced this pull request Jan 22, 2025
christophfroehlich pushed a commit that referenced this pull request Jan 22, 2025
Co-authored-by: Victor Coutinho Vieira Santos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants