Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pid_controller] Update tests #1538

Merged

Conversation

Juliaj
Copy link
Contributor

@Juliaj Juliaj commented Feb 13, 2025

Main changes

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 89.85507% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (c83cfb3) to head (9c0920c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pid_controller/src/pid_controller.cpp 58.82% 3 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
+ Coverage   84.27%   84.38%   +0.10%     
==========================================
  Files         123      124       +1     
  Lines       11359    11386      +27     
  Branches      961      959       -2     
==========================================
+ Hits         9573     9608      +35     
+ Misses       1470     1462       -8     
  Partials      316      316              
Flag Coverage Δ
unittests 84.38% <89.85%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
pid_controller/test/test_pid_controller.cpp 100.00% <100.00%> (ø)
pid_controller/test/test_pid_controller.hpp 84.78% <ø> (ø)
...roller/test/test_pid_controller_dual_interface.cpp 100.00% <100.00%> (ø)
pid_controller/src/pid_controller.cpp 72.03% <58.82%> (+3.61%) ⬆️

... and 4 files with indirect coverage changes

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Feb 13, 2025
@christophfroehlich
Copy link
Contributor

FYI: some of the changes are already included in #1437. I marked that ready for review now, as it got released and merged into ros2-testing.

Copy link
Contributor

mergify bot commented Feb 13, 2025

This pull request is in conflict. Could you fix it @Juliaj?

@Juliaj Juliaj changed the title [pid_controller] Clean up deprecated code and update tests [pid_controller] Update tests Feb 13, 2025
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for adding more tests and the cleanup!

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
I just added a convenience function set_reference to TestablePidController, we have repeated that 10times already.

@christophfroehlich christophfroehlich merged commit b24b310 into ros-controls:master Feb 14, 2025
18 of 26 checks passed
mergify bot pushed a commit that referenced this pull request Feb 14, 2025
(cherry picked from commit b24b310)

# Conflicts:
#	pid_controller/src/pid_controller.cpp
#	pid_controller/test/pid_controller_params.yaml
#	pid_controller/test/test_pid_controller.cpp
#	pid_controller/test/test_pid_controller.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants