Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh colour #142

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Mesh colour #142

merged 3 commits into from
Mar 25, 2019

Conversation

christian-rauch
Copy link
Contributor

@christian-rauch christian-rauch commented Jan 18, 2019

This PR adds colour (black) to the articulated meshes. Fixes #141

Edit: I just saw that I had other commits in my devel branch. There are two commits to fix the installation and running of the simulation launch file.

@christian-rauch christian-rauch changed the base branch from jade-devel to kinetic-devel January 18, 2019 20:40
Copy link
Contributor

@jproberge jproberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice simple PR. This definitely improves visualisation for the 3-F gripper. Working with Collada files (dae) instead of STLs for visualisation is great as it has many advantages.

The only thing here that I find problematic is only aesthetic and is the chosen colour. I know the intention was probably to be as close as possible to the real gripper's colour, but the colour that was chosen is too dark, such that we cannot really see the gripper's details anymore (which could make it more difficult for some people, for example, to set up their simulation compared to the previous white (no colour) version), see:

3fgrippergazebo

Before a more accurate colour reference is provided by Robotiq (I'll ask them for one), would you agree to use a "brighter" colour, anything that would allow one to better see the gripper details, such as a dark-but-not-black grey? I could also do it if needed.

Thanks for the PR!

@christian-rauch
Copy link
Contributor Author

If someone else is interested in using this right now, I am happy to change to colour to something lighter.

It would be great if we could have proper "official" colour, or, even better, material properties from Robotiq. Robotiq provides a STEP file for the 3-Finger Adaptive Robot Gripper on their homepage:
https://assets.robotiq.com/production/support_documents/document/ROBOTIQ_AGS-001-XXXX_20171116.STEP but I was not able to convert it to a dae mesh file and keep the texture information. Textured dae mesh files (extracted from the STEP or provided by Robotiq) would be much better than the uniformly coloured meshes we have now.

@christian-rauch
Copy link
Contributor Author

@jproberge Is there any news on an "official" colour/material definition from Robotiq?
If this is not happening in the short term, I am happy if you change the colour to something slightly lighter.

Maybe the issue is also with the material definition and not the colour per se. In Blender, the palm mesh shows more shading than in Gazebo:
rq_palm_blender

@jproberge
Copy link
Contributor

hi @christian-rauch ,

Thanks for your follow-up! I will have the information this week and I'll post back as soon as possible. Also, I agree that it depends on the visualisation environment. At the end, it's just aesthetic, so I don't want to delay this PR too much, and I'll post back here this week as soon as I get the information.

Thanks again!

jproberge

@jproberge
Copy link
Contributor

@christian-rauch,

I'm accepting this PR, since I've reviewed / tested it and found that it works flawlessly and is an improvement. Also, Robotiq told me that there were no precise color definition. In fact they ask their supplier to provide black anodized parts, but then these parts are also subject to a tumbler surface finish process, which might also alter the colour a little. Thus no precise colour definition. Thanks!

@jproberge jproberge merged commit 056b063 into ros-industrial-attic:kinetic-devel Mar 25, 2019
@christian-rauch christian-rauch deleted the mesh_colour branch March 25, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gazebo models have no colour
2 participants