Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mimic joint limits #157

Conversation

onionsflying
Copy link
Contributor

Hi,
I'm using gazebo to simulate robotiq_2f_140_gripper with the MimicJointPlugin. Some problems occurred. Then I found that the mimic joint limits were wrong. For example, the limits of left_inner_knuckle_joint and right_inner_knuckle_joint should be [-0.8757, 0] and [0, 0.8757], but they were both set as [0, 0.8757]. Since they are mimic joints, I think the simplest solution is to set the joint limits symmetrically.

Copy link
Contributor

@jproberge jproberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good timing, this is exactly the same concern as #119 which was merged recently, but for another branch. Thank you, I'm merging this as this was indeed a needed fix.

@jproberge jproberge merged commit 29d0d13 into ros-industrial-attic:kinetic-devel Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants