Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated French comments to English #169

Merged
merged 2 commits into from
Oct 18, 2019
Merged

Translated French comments to English #169

merged 2 commits into from
Oct 18, 2019

Conversation

lit-af
Copy link
Contributor

@lit-af lit-af commented Oct 15, 2019

I translated the French comments to English while maintaining the original author's intent. This should close issue #90

@lit-af
Copy link
Contributor Author

lit-af commented Oct 15, 2019

@jproberge Would you mind reviewing this PR in the next week? I'm doing this for Hacktoberfest.

jproberge
jproberge approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@jproberge jproberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find these translations to be good enough to be merged
Je trouve que ces traductions sont suffisamment bonnes pour les joindre au repo :)

@jproberge jproberge merged commit 302c5c6 into ros-industrial-attic:kinetic-devel Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jproberge jproberge jproberge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lit-af @jproberge