Add support for GP225 robot #583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Yaskawa Motoman GP225 robot
gavanderhoorn
requested changes
Jan 31, 2025
| <b>Specifications</b> | ||
| </p> | ||
| <ul> | ||
| <li>GP225 - Default</li> |
There was a problem hiding this comment.
Similar to #607, the xacro:macro appears to model what Table 5-1: Basic Specifications (YR-1-06VX225-A00) labels as Not-equipped:
Should we update this as well:
Suggested change
| <li>GP225 - Default</li> | |
| <li>GP225 - Not-equipped</li> |
?
Comment on lines
+28
to
+32
| <p> | ||
| NOTE: the base model xacro macro has all joints oriented such that they | ||
| rotate around the Z+ axis. As a consequence, link frames in this model | ||
| do not follow REP-103 wrt frame orientation. | ||
| </p> |
There was a problem hiding this comment.
This does not appear to be true for this package.
Copy-pasta?
There was a problem hiding this comment.
This mesh gets rendered with an unexpected greenish washed out colour for me:
Should this not be black?
Meshes in general look like they might be downsampled a bit too much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Yaskawa Motoman GP225 robot