Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick missing commits from kinetic-devel into melodic-devel #501

Conversation

gavanderhoorn
Copy link
Member

@gavanderhoorn gavanderhoorn commented Jun 9, 2020

As per subject.

This gets melodic-devel-staging to the same state (functionally) as current kinetic-devel.

melodic-devel was branched off of kinetic-devel at a point where releases 1.2.6 and 1.2.7 hadn't been made yet, so three commits were missing (see the diff).

Rebasing melodic-devel-staging is not an option as it then cannot be merged with melodic-devel.

PRs 'merged' in this PR:

tfoote and others added 2 commits June 9, 2020 14:48
Legacy __print__ statements are syntax errors in Python 3 but __print()__ function works as expected in both Python 2 and Python 3.
@gavanderhoorn gavanderhoorn force-pushed the port_kinetic-devel_missing branch from 97de361 to d730bb5 Compare June 9, 2020 15:31
@gavanderhoorn
Copy link
Member Author

Dropped the MoveIt e-Series commit as this will be fixed later, makes this PR fail and it makes little sense to fix that now just to pass CI.

@gavanderhoorn gavanderhoorn merged commit 4215b69 into ros-industrial:melodic-devel-staging Jun 9, 2020
@gavanderhoorn gavanderhoorn deleted the port_kinetic-devel_missing branch June 9, 2020 16:28
@gavanderhoorn gavanderhoorn added this to the melodic-devel-staging milestone Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants