A couple of fixes for path handling #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that indexing into the files in a git tree only works with POSIX paths, so the Windows native paths need to be converted. Additionally, I made a bad assumption about the 'python.yaml' file name in the rosdep analyzer. That change should have no effect on POSIX systems, and makes Windows runs more consistent.
cottsay
force-pushed
the
cottsay/rosdep-win-paths
branch
from
73192ab to
e6f385d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 39.10% 38.90% -0.21%
==========================================
Files 12 12
Lines 583 586 +3
Branches 154 154
==========================================
Hits 228 228
- Misses 350 353 +3
Partials 5 5 ☔ View full report in Codecov by Sentry. |
tfoote
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that indexing into the files in a git tree only works with POSIX paths, so the Windows native paths need to be converted.
Additionally, I made a bad assumption about the 'python.yaml' file name in the rosdep analyzer. That change should have no effect on POSIX systems, and makes Windows runs more consistent.