Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop references to requesting review from github-actions[bot] #29

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Nov 20, 2024

I'm confident that this was working as described when I wrote this tool, but GitHub's behavior appears to have changed and requesting review from the github-actions[bot] doesn't appear to do anything anymore.

We'll have to run the reviewer on push like other GitHub Actions automations.

@cottsay cottsay self-assigned this Nov 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.51%. Comparing base (eef582b) to head (67e4aef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #29   +/-   ##
=======================================
  Coverage   87.51%   87.51%           
=======================================
  Files          13       13           
  Lines         689      689           
  Branches      169      169           
=======================================
  Hits          603      603           
  Misses         64       64           
  Partials       22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

Maybe mentioning the result of changing the action to act on push in the main README.md by changing: "When a rosdistro pull request is opened" to something like "When a rosdistro pull request is opened or updated".

Copy link

@nuclearsandwich-ai nuclearsandwich-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this winds up being "too spammy" we can consider magic comments a la ros-pull-request builder retest this please.

I'm confident that this was working as described when I wrote this tool,
but GitHub's behavior appears to have changed and requesting review from
the github-actions[bot] doesn't appear to do anything anymore.

We'll have to run the reviewer on push like other GitHub Actions
automations.
@cottsay cottsay force-pushed the cottsay/remove-review-request branch from e83851a to 67e4aef Compare November 20, 2024 17:48
@cottsay
Copy link
Member Author

cottsay commented Nov 20, 2024

Maybe mentioning the result of changing the action to act on push in the main README.md by changing: "When a rosdistro pull request is opened" to something like "When a rosdistro pull request is opened or updated".

Done, thanks for the suggestion.

@cottsay cottsay merged commit 095c6fe into main Nov 20, 2024
18 checks passed
@cottsay cottsay deleted the cottsay/remove-review-request branch November 20, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants