-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow null user_doc_dir in rosdoc2.yaml to ignore documentation. #153
Conversation
One thought reading this quickly but not having time to fully review. We also have a documentation url in the package.xml we should make sure not to duplicate. |
You've got a good point. If you look at my use of this option, all of the use cases are combined with suppressing the API generation. So the concept that needs expressing is sort of "We have externally-generated extensive documentation, with our own Doxygen and/or Sphinx options that are properly executed. Don't try to guess what we want, just show our documentation." The documentation link is more "Here's an external site that might also be helpful." They might point to the old Wiki, or just to their repo. So there are in my mind two distinct sets of situations that need options. |
@tfoote I thought about what you said, and I think the right thing to do is going to be to invert the meaning of this option, so the option instead disables the display of the "Documentation" link outside of the "Link" section. The usage is for large projects that have their own website that generates complete documentation using possibly the doc/ directory. Out display of that directory is then duplicative. They can the rely on the Links/Documentation exposure of their website. I'll leave the other (future PR) options of |
Yeah, I like that idea to basically make this say there's external project documentation and it should link to that instead of building locally. |
Signed-off-by: R. Kent James <[email protected]>
548ade0
to
e9c8a77
Compare
OK I edited this as we discussed. Now you can specify user_doc_dir: null in rosdoc2.yaml, and any documentation in doc/ or doc/source/ will not appear in a Documentation section. The intention here is for large projects that generate external documentation, using the doc/ directory of the package, to tell rosdoc2 to ignore those files. We expect (but do not require) that external documentation link to be set as in package.xml. |
Just as an additional note, there is a PR to come that will replace the rosdoc2 output in its entirety with the external documentation. This current PR still shows the default rosdoc2 output, it just ignores anything under doc/ to reduce duplication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed this review in the queue. lgtm
Some of the larger projects have their own documentation that is built independently of rosdoc2. Rather than trying to duplicate their efforts, we should just allow the projects to add their own link in the 'documentation' area of rosdoc2.
This has the downside that the user leaves the rosdoc2 site, but I still think it is the better option for these projects.
When this PR is built, it should not show any changes since this is a new unused option, but you could see it in the tests. In my full runs, there are a number of sites with this applied (using the previous PR --yaml-extend): pinocchio, fastrtps, beluga, ign_rviz, grbl_ros, fields2cover, depthai-ros. So for example see https://rosdoc2.rosdabbler.com/humble/fields2cover/ and check the Documentation link. (These all also have additional options applied to suppress the local building of Doxygen, which is not part of the current PR).