Add Docker container for development #307
Conversation
The CI system picked up non-conformance issues with recent changes to the ebuild generator. Fix lines that exceed 79 characters and remove an used chunk_count variable. Signed-off-by: Rob Woolley <[email protected]>
|
The CI tests fail with the following message: These are not files being changed in this commit. They are specific to the ebuild generator which is unrelated to the Docker container. This is solved by #308 . |
Signed-off-by: Rob Woolley <[email protected]>
Signed-off-by: Rob Woolley <[email protected]>
| @@ -0,0 +1,38 @@ | |||
| # superflore-devel | |||
There was a problem hiding this comment.
I don't remember exactly how python packaging handles extraneous files. Do we need to explicitly "ignore" these so that they aren't incorporated into the packaged archive or does this count as a data file which pip won't include unless told.
There was a problem hiding this comment.
Thanks, I'll look into this.
There was a problem hiding this comment.
This doesn't seem to be a problem for Setuptools, Poetry, Flit, Hatch, or PDM. Most have explicit include and excludes lists, but setuptools also has a few pre-defined files that get automatically included: https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html
It doesn't seem like the Dockerfile or setup script would get automatically included.
This Docker container is based on the osrf/ros2:devel container image. It adds the additional dependencies required to develop superflore.
It may be used independently, but it is intended for use as a VSCode devcontainer for development of superflore.