Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route Tool Rviz Panel #4775

Open
wants to merge 35 commits into
base: nav2_route_server
Choose a base branch
from
Open

Route Tool Rviz Panel #4775

wants to merge 35 commits into from
+2,343 −26

Conversation

john-chrosniak
Copy link

Basic Info

Info Please fill out this column
Ticket(s) this addresses NA
Primary OS tested on Ubuntu
Robotic platform tested on Gazebo turlebot simulation and Ackermann steering robot
Does this PR contain AI generated software? Yes and it is marked inline in the code

Description of contribution in a few bullet points

  • I added an Rviz panel to help create route graphs

Description of documentation updates required from your changes

  • Documentation needed to highlight how to use the new Rviz panel

Future work that may be required in bullet points

  • Could add support for bidirectional edges or adding route operations using the tool in future work

For Maintainers:

  • Check that any new parameters added are updated in docs.nav2.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 2, 2024

@john-chrosniak, all pull requests must be targeted towards the main development branch.
Once merged into main, it is possible to backport to @nav2_route_server, but it must be in main
to have these changes reflected into new distributions.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024

This pull request is in conflict. Could you fix it @john-chrosniak?

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024

This pull request is in conflict. Could you fix it @john-chrosniak?

@john-chrosniak john-chrosniak force-pushed the route-server-develop branch 2 times, most recently from 91d39a1 to c2a4add Compare December 4, 2024 18:08
SteveMacenski and others added 23 commits December 4, 2024 13:51
@SteveMacenski @john-chrosniak
new image
5eaa17a 
Signed-off-by: John Chrosniak <[email protected]>
@SteveMacenski @john-chrosniak
tmp push for moving computers
2d8f1ec 
Signed-off-by: John Chrosniak <[email protected]>
@jwallace42 @john-chrosniak
turtlebot3 world graph (ros-navigation#3472)
de59ae6 
* turtlebot3 world graph

* remove line

* add line back

Signed-off-by: John Chrosniak <[email protected]>
@jwallace42 @john-chrosniak
scripts for route (ros-navigation#3490)
a4dbb5d 
Signed-off-by: John Chrosniak <[email protected]>
@adamlm @john-chrosniak
Patch repo to build from source with Humble (#1)
439e488 
* Revert rclcpp service API usage for Humble

rclcpp deprecated one of the create_service() function overloads, and
the navigation2 projected updated their usage accordingly. However,
these API changes did not get back-ported to the rclcpp version that
Humble uses, meaning we could not build navigation2 packages from
source with Humble.

* Remove launch substitutions that are unavailable in Humble

* Update include directive to use proper header file name

The cv_bridge package added a .hpp file, but only the .h version is
available in Humble.

* Update README with changes from upstream

* Remove upstream's CI workflows

Signed-off-by: John Chrosniak <[email protected]>
@adamlm @john-chrosniak
Fix bad GeoJSON files and shift map (#2)
35ff4c7 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
added route tool skeleton code and gui
0bded21 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
rviz2 panel can load route graph
c30e5fe 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
can add nodes using route tool
efcd5c1 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
added logic for creating edges
5c944ce 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
graph nodes can be edited, existing edges will still connect if a nod…
6d2ba07 
…e is moved

Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
can edit edges
46990ab 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
can delete nodes and edges
5640c77 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
route graphs can be saved
3d8b956 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
fixed bug for loading in route graphs
ada58f5 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
added dynamic text to UI, created launch file and rviz configuration
38a3fdb 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
fixed bug for deleting nodes
2935f71 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
actually fixed node removal bug
ecf4608 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
publishing clicked point populates x and y fields
8ad1b27 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
removed debugging log statements
4e089aa 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
added check to make sure node/edges exist before editing
aef4bfc 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
bug fix
8d91a7b 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
migrated route tool to rviz plugin
e1e0609 
Signed-off-by: John Chrosniak <[email protected]>
john-chrosniak and others added 11 commits December 4, 2024 13:51
@john-chrosniak
minor refactoring
5f29eb9 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
added metadata and operations to graph saver so nothing should be erased
69f94d9 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
edited set route service to clear current route before setting new
657ad71 
Signed-off-by: John Chrosniak <[email protected]>
@SaikrishnaBairamoni @john-chrosniak
Update README.md
d188c46 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
addressed comments
447d5d1 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
documentation cleanup
c78364d 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
changed copyright
1fc2af4 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
addressed comments
00e4ab9 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
moved copyright due to compiler error
9b004c9 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
revert removal of files
7aeeafb 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak
added gen ai comment
752caf0 
Signed-off-by: John Chrosniak <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024

This pull request is in conflict. Could you fix it @john-chrosniak?

@john-chrosniak
reverted unneeded changes
b154d78 
Signed-off-by: John Chrosniak <[email protected]>
@john-chrosniak john-chrosniak mentioned this pull request Jan 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@john-chrosniak @SteveMacenski @jwallace42 @adamlm @SaikrishnaBairamoni