Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes several changed to the
RadarReturn
andRadarScan
messages.Summary
Time stamp
The current message for a
RadarScan
just stores one time stamp for all returns.And this time stamp is not clearly defined.
Proposed change
stamp_offset
toRadarReturn
, which will be used relatively to the time stamp of the time stamp in the fieldheader
ofRadarScan
.header
ofRadarScan
to be of the first return.Usage of the spherical angles
The current description for the
azimuth
andelevation
angles doesn't directly specify the order of these angles.From the comment for
elevation
"For 2D radar, this will be 0." the order can be deducted, but it could be clearer.Proposed change
Missing Measurement characteristics
While for LiDAR sensors the measured returns are typically treated as points, this behavior is problematic for radar sensors.
Proposed change
sensor_properties
toRadarScan
SensorProperties
to group the information about the device used for the measurement.Missing definition of amplitude
The description for the field
amplitude
is missing the relative information of the measurement.Proposed change
(Please note that this also changes the logarithmic value to a linear one.)