Add missing namespaces

[jspricke]

No description provided.

[wjwwood]

Can you provide some context as to why this is needed? Should the *SharedPtr typedefs be inside a namespace (urdf) as well? @rhaschke

[jspricke]

ModelInterface is in the urdf namespace, so we have to add it, otherwise gcc complains. Adding the namespace to the *SharedPtr definitely makes sense. Actually why not move them into urdf/include/urdf/model.h?

[rhaschke]

I don't see a reason, why the explicit namespace is needed. All these types are declared within a namespace urdf. Some older gcc might have issues with that.
Moving the declaration to urdf/include/urdf/model.h doesn't make sense, as ModelInterfaceis a type defined by urdfdom_headers, not the urdfpackage. However, I suggested to have this declaration in urdf_headersinstead: ros/urdfdom_headers#33. Unfortunately, nobody commented on this idea yet.

[rhaschke]

To be on the safe side, I suggest to explicitly state ::urdf::ModelInterface.

[jspricke]

urdf namespace ends in line 72 whereas these defines are in 78ff. gcc 6.2.0 (current Debian unstable) complained.

[rhaschke]

urdf namespace ends in line 72 whereas these defines are in 78ff. gcc 6.2.0 (current Debian unstable) complained.

Oh, indeed. I missed that. In this case, please extend the namespace to lines 78ff. as the SharedPtr types should reside in that namespace too as suggested in #165 (comment).

[jspricke]

Tested and works fine with new added namespace

[jspricke]

I've inegrated this into #144.