Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rplidar_ros: 1.5.2-1 in 'jade/distribution.yaml' [bloom] #11216

Merged
merged 1 commit into from
Apr 22, 2016
Merged

rplidar_ros: 1.5.2-1 in 'jade/distribution.yaml' [bloom] #11216

merged 1 commit into from
Apr 22, 2016

Conversation

kintzhao
Copy link
Contributor

Increasing version of package(s) in repository rplidar_ros to 1.5.2-1:

rplidar_ros

1.5.1 (2016-04-12)
* Release 1.5.1.
* Add the deiver support rplidar A2.
* Contributors: yhZhao, RoboPeak Public Repos

@wjwwood
Copy link
Member

wjwwood commented Apr 22, 2016

Thanks! We'll see if this one works.

@wjwwood wjwwood merged commit bf2efef into ros:master Apr 22, 2016
@wjwwood
Copy link
Member

wjwwood commented Apr 22, 2016

This one did not work either.

@wjwwood
Copy link
Member

wjwwood commented Apr 22, 2016

@kintzhao I'm not sure what you're doing wrong, but the source deb job fails still with the same error...

@wjwwood
Copy link
Member

wjwwood commented Apr 22, 2016

@kintzhao I'd recommend deleting this: https://github.com/robopeak/rplidar_ros/blob/master/tracks.yaml, but I don't think that's the root of the issue.

@wjwwood
Copy link
Member

wjwwood commented Apr 22, 2016

Also your changelog has a weird formatting where the 1.5.2 entry is in there twice:

https://github.com/robopeak/rplidar_ros/blob/master/CHANGELOG.rst

You need to fix that up, but again I don't know if that's the problem with your release.

@wjwwood
Copy link
Member

wjwwood commented Apr 22, 2016

@kintzhao I looked at your repositories and I can't deduce what the exact issue is. I'd recommend fixing the two things I pointed out in the comments above and try again.

If that doesn't work, I'd recommend creating a different release repository for jade and trying that, e.g. something like robopeak/rplidar_ros-jade-release. This would workaround any issues that linger in the existing release repository.

Sorry for the trouble you're having. I'll keep an eye out for your fixes and next attempts.

@kintzhao
Copy link
Contributor Author

@wjwwood I do it following your two advice. Is there release rplidar_ros in jade version ok ?
But http://wiki.ros.org/rplidar Package Links: the Jenkins jobs(12) status can not be loaded.

Pull Request #11256 Fixed the release jade version of rplidar_ros .
Commit e6687cc
#11256: Fixed the release jade version of rplidar_ros .
avatar kint.zhao authored and committed
#21375 passed

@wjwwood
Copy link
Member

wjwwood commented Apr 24, 2016

Why did you manually create #11256? Why not just let bloom open the pull request?

@kintzhao
Copy link
Contributor Author

@wjwwood I have ever closed a pull request, I want to pull request again, so open #11256 . sorry for that i am fresh about release a ros version.. #11174 , #11175, #11196 ,#11212 ,#11256 all my action. why rplidar_ros Package Links: the Jenkins jobs(12) status can not be loaded. and apt-get cannot find ros-jade-rplidar-ros in the jade version. How can i check if and fixed it ?

@kintzhao kintzhao deleted the bloom-rplidar_ros-1 branch May 2, 2016 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants