Do not install CMake config files in a different directory on Windows #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small cleanup that would make sense to get in urdfdom 4.
CMake config files were installed in a different directory in #41 as a workaround for a CMake issue on discoverability of packages installed in the default Windows install prefix (https://gitlab.kitware.com/cmake/cmake/issues/16212) that was fixed in CMake 3.7 (https://gitlab.kitware.com/cmake/cmake/-/merge_requests/68), so the workaround is not necessary when using CMake >= 3.7 (released ~7 years ago). Note that install on CMake <= 3.7 continues to work fine, the only thing that does not work is finding automatically a urdfdom installed in the default install prefix.
This PR removes the workaroud, and installs CMake config files in the same location for all OS, i.e.
${CMAKE_INSTALL_LIBDIR}/${PROJECT_NAME}/cmake
. It is convenenient to have this merged before urdfdom 4 because:TinyXML2.cmake
installed in Upgrade from tinyxml to tinyxml2 #186 is installed in a project-specific location also on Windows.fyi @clalancette