Fix marshalling bool parameters and return values in pInvokes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not change the C# side of the generated messages to avoid even more complexity in the templates. As bools in C# pInvokes get marshalled as 32 bit integer by default there is no strictly need to change the code for bool fields.
hoffmann-stefan
force-pushed
the
feature/fix-bool-pInvoke
branch
from
e8da301 to
86b182c
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from #94
This fixes Issues with bools that where interpreted wrong in release builds and therefore causing wrong behavior.
See https://www.mono-project.com/docs/advanced/pinvoke/#boolean-membersfor more information on marshalling bools.
Took the following path:
inton C# side andint32_ton the c side instead of bool for the library code to make this as explicit as it gets and avoidboolentirely.boolon C# side andint32_ton the c side in the messages code. This avoids having to ad special cases to the C# template for the code generation. Asbools in C# pInvokes get marshalled as 32 bit integer by default there is no need to change the code forboolfields.