Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build errors : static link wait_set_subscriber_library #349

Closed
wants to merge 1 commit into from
Closed

Windows build errors : static link wait_set_subscriber_library #349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rclcpp/topics/minimal_subscriber/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ ament_target_dependencies(subscriber_not_composable rclcpp std_msgs)
add_executable(subscriber_content_filtering content_filtering.cpp)
ament_target_dependencies(subscriber_content_filtering rclcpp std_msgs)

add_library(wait_set_subscriber_library SHARED
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rclcpp_components_register_node below is registering this as a plugin. This can only be used with shared libraries. I don't think the problem in #344 is this library being a shared library; instead, I think there's a problem is in whatever is expecting it not to be one.

add_library(wait_set_subscriber_library STATIC
wait_set_subscriber.cpp
static_wait_set_subscriber.cpp
time_triggered_wait_set_subscriber.cpp)
Expand Down