Code

Kill dangling subprocesses#632

Code

Open

ivanpauno wants to merge 17 commits intorollingros2/launch:rollingfrom ivanpauno/kill-dangling-subprocessesros2/launch:ivanpauno/kill-dangling-subprocessesCopy head branch name to clipboard

+131-17

Commits

Commits on Dec 5, 2022

• Kill dangling subprocesses

  Show description for f86971a
  ivanpauno

  committed
  f86971a

  Copy full SHA for f86971a

• Address peer review comments

  Show description for d268600
  ivanpauno

  committed
  d268600

  Copy full SHA for d268600

• Fix docstring

  Show description for b5a925f
  ivanpauno

  committed
  b5a925f

  Copy full SHA for b5a925f

• Remove leftover comments

  Show description for e2b1a3c
  ivanpauno

  committed
  e2b1a3c

  Copy full SHA for e2b1a3c

• Undo unneeded change

  Show description for 8466b49
  ivanpauno

  committed
  8466b49

  Copy full SHA for 8466b49

• Cleanup subprocesses before respawning

  Show description for 2356223
  ivanpauno

  committed
  2356223

  Copy full SHA for 2356223

• please flake8

  Show description for ac6afd3
  ivanpauno

  committed
  ac6afd3

  Copy full SHA for ac6afd3

• Fix issue detected in tests

  Show description for 7ffee9a
  ivanpauno

  committed
  7ffee9a

  Copy full SHA for 7ffee9a

• Improve error handling

  Show description for 6432d76
  ivanpauno

  committed
  6432d76

  Copy full SHA for 6432d76

• Address peer review comments

  Show description for 6284c82
  ivanpauno

  committed
  6284c82

  Copy full SHA for 6284c82

• Remove unnecessary argument in __get_shutdown_timer_actions()

  Show description for 514c149
  ivanpauno

  committed
  514c149

  Copy full SHA for 514c149

• Add test case

  Show description for 5b43cdc
  ivanpauno

  committed
  5b43cdc

  Copy full SHA for 5b43cdc

Commits on Dec 14, 2022

• Fix flake8 failures

  Show description for 4b796cc
  ivanpauno

  committed
  4b796cc

  Copy full SHA for 4b796cc

• More flake8 failures

  Show description for 58cd661
  ivanpauno

  committed
  58cd661

  Copy full SHA for 58cd661

Commits on Dec 20, 2022

• Seems to fix CI issues...

  Show description for 5ff2f05
  ivanpauno

  committed
  5ff2f05

  Copy full SHA for 5ff2f05

• Second try

  Show description for b5ba458
  ivanpauno

  committed
  b5ba458

  Copy full SHA for b5ba458

• another try

  Show description for fc97730
  ivanpauno

  committed
  fc97730

  Copy full SHA for fc97730