-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create py.typed to mark this library as typed #379
Conversation
1427254
to
1287e9b
Compare
I'm not quite sure how that caused the failed test in the Rpr__launch_ros__ubuntu_jammy_amd64 CI, that might be unrelated? Apropos CI: In the linked rclpy PR there is some discussion on testing. Pyright can test libraries for type correctness, but this test currently fails for launch_ros:
It does however also fail for rclpy:
I think it still makes sense to mark this as "supposed to by typed" (if this is the intention, i assume this based on the large amount of type hints), it works well for rclpy. edit: for reference: the pyright documentation for libraries: https://microsoft.github.io/pyright/#/typed-libraries?id=typing-guidance-for-python-libraries |
Yeah, it's unrelated. It should be fixed by #377 |
Signed-off-by: Jonas Otto <[email protected]>
9293b0f
to
b0f3680
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating! This looks good to me, I'll run CI on it next.
Signed-off-by: Jonas Otto <[email protected]>
b0f3680
to
7ffd13b
Compare
Looks good, thanks for iterating! |
This marker file informs type checkers of downstream libraries that launch_ros is typed.
In my use case, this enables using the
strict
typechecking mode in pyright for a downstream project using launch_rosThis was done for rclpy in ros2/rclpy#946