Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO to reenable tests on rclcpp for content filtering #281

Merged
merged 3 commits into from
Sep 12, 2024
Merged

TODO to reenable tests on rclcpp for content filtering #281

merged 3 commits into from
Sep 12, 2024

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 12, 2024

No description provided.

@ahcorde ahcorde requested a review from Yadunund September 12, 2024 10:39
@ahcorde ahcorde self-assigned this Sep 12, 2024
@ahcorde ahcorde marked this pull request as ready for review September 12, 2024 10:39
Yadunund
Yadunund requested changes Sep 12, 2024
View reviewed changes
Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with the comments in the code but i'd also prefer having an an issue ticket in this repo that keeps track of all the features we need to develop and tests we need to re-enable.

rmw_zenoh_cpp/src/rmw_zenoh.cpp Outdated Show resolved Hide resolved
rmw_zenoh_cpp/src/rmw_zenoh.cpp Outdated Show resolved Hide resolved
ahcorde and others added 2 commits September 12, 2024 22:41
@ahcorde @Yadunund
Update rmw_zenoh_cpp/src/rmw_zenoh.cpp
077ef50 
Co-authored-by: Yadu <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@ahcorde @Yadunund
Update rmw_zenoh_cpp/src/rmw_zenoh.cpp
c7b20c6 
Co-authored-by: Yadu <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>
@Yadunund Yadunund merged commit aa69da9 into rolling Sep 12, 2024
8 checks passed
@Yadunund Yadunund deleted the ahcorde/rolling/content_filtering_note branch September 12, 2024 22:26
imstevenpmwork pushed a commit to ZettaScaleLabs/rmw_zenoh that referenced this pull request Sep 23, 2024
@ahcorde @Yadunund @imstevenpmwork
TODO to reenable tests on rclcpp for content filtering (ros2#281)
3122fa5 
* TODO to reenable tests on rclcpp for content filtering

Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Update rmw_zenoh_cpp/src/rmw_zenoh.cpp

Co-authored-by: Yadu <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>

* Update rmw_zenoh_cpp/src/rmw_zenoh.cpp

Co-authored-by: Yadu <[email protected]>
Signed-off-by: Alejandro Hernández Cordero <[email protected]>

---------

Signed-off-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Yadu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

Assignees

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @Yadunund