Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ZENOH_ROUTER_CHECK_ATTEMPTS which was not respected (backport #427) #428

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fix ZENOH_ROUTER_CHECK_ATTEMPTS which was not respected (backport #427) #428

merged 1 commit into from
Jan 17, 2025

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Jan 17, 2025

Fix #426

  1. The call to std::vector<Id> Session::get_routers_z_id(ZResult*) was checking the ZResult, but not the size of the returned vector.
  2. in Don't block in rmw_init checking for the router. #308 the default value of ZENOH_ROUTER_CHECK_ATTEMPTS was changed from 0 to 1. This PR updates the README to reflect this change, and clarify the behaviour after the checks complete.
    This is an automatic backport of pull request Fix ZENOH_ROUTER_CHECK_ATTEMPTS which was not respected #427 done by Mergify.

@JEnoch @mergify
Fix ZENOH_ROUTER_CHECK_ATTEMPTS which was not respected (#427)
589993a 
* Fix check of connection to a router

* README: update ZENOH_ROUTER_CHECK_ATTEMPTS following default value change in #308

(cherry picked from commit 6f910bf)
@mergify mergify bot mentioned this pull request Jan 17, 2025
Merged
@Yadunund Yadunund merged commit 8bbca81 into jazzy Jan 17, 2025
4 checks passed
@Yadunund Yadunund deleted the mergify/bp/jazzy/pr-427 branch January 17, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yadunund Yadunund Yadunund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yadunund @JEnoch