Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jobs for Iron Irwini #313

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Remove jobs for Iron Irwini #313

merged 1 commit into from
Feb 4, 2025

Conversation

Yadunund
Copy link
Member

@Yadunund Yadunund commented Dec 9, 2024

Iron is now EOL.

Note: Marking this as draft until the final snapshots of Iron are captured.

Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as an FYI, what we usually do here is to mark the jobs as "Disabled" on the buildfarm for a month or so. That way, if something catastrophic happens and we need to do another release, it is easy to turn on. After that, we usually merge a PR like this and delete the builds from the buildfarm.

Thus, while this is the correct thing to do, I suggest we hold off on merging this until at least January.

@Yadunund
Copy link
Member Author

Yadunund commented Dec 9, 2024

Sounds good. I'll leave it as draft until then.

@Yadunund Yadunund marked this pull request as ready for review February 4, 2025 06:51
@Yadunund Yadunund requested a review from cottsay as a code owner February 4, 2025 06:51
@Yadunund
Copy link
Member Author

Yadunund commented Feb 4, 2025

We learnt that disabling jobs in the buildfarm is temporary and as long as these configs exist, the jobs will be re-created/enabled.

It's been over a month since Iron was marked as EOL and no issues have been reported. I've tagged the latest commit on this repo as iron-20250203-config.

This PR is ready for review / merge.

Copy link

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but let's wait to merge until @nuclearsandwich has had a chance to review.

@Yadunund Yadunund merged commit 9910700 into ros2 Feb 4, 2025
3 checks passed
@Yadunund Yadunund deleted the yadu/iron-eol branch February 4, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants