Skip to content

Commit

Permalink
Fix Valkey binary build workflow, version support changes. (valkey-io…
Browse files Browse the repository at this point in the history
…#1429)

This change makes the binary build on the target ubuntu version.

This PR also deprecated ubuntu18 and valkey will not support:

- X86:
  - Ubuntu 20
  - Ubuntu 22
  - Ubuntu 24
 - ARM:
   - Ubuntu 20
   - Ubuntu 22
   
Removed ARM ubuntu 24 as the action we are using for ARM builds does not
support Ubuntu 24.

---------

Signed-off-by: Roshan Khatri <[email protected]>
  • Loading branch information
roshkhatri authored Dec 12, 2024
1 parent ab69a8a commit 3a1043a
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/call-build-linux-x86-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
build-valkey:
# Capture source tarball and generate checksum for it
name: Build package ${{ matrix.distro.target }} ${{ matrix.distro.arch }}
runs-on: "ubuntu-latest"
runs-on: ${{matrix.distro.target}}
strategy:
fail-fast: false
matrix: ${{ fromJSON(inputs.build_matrix) }}
Expand Down
21 changes: 8 additions & 13 deletions utils/releasetools/build-config.json
Original file line number Diff line number Diff line change
@@ -1,29 +1,24 @@
{
"linux_targets": [

{
"arch": "x86_64",
"target": "ubuntu18.04",
"target": "ubuntu-20.04",
"type": "deb",
"platform": "bionic"
"platform": "focal"
},
{
"arch": "x86_64",
"target": "ubuntu20.04",
"target": "ubuntu-22.04",
"type": "deb",
"platform": "focal"
"platform": "jammy"
},
{
"arch": "x86_64",
"target": "ubuntu24.04",
"target": "ubuntu-24.04",
"type": "deb",
"platform": "noble"
},
{
"arch": "arm64",
"target": "ubuntu18.04",
"type": "deb",
"platform": "bionic"
},
{
"arch": "arm64",
"target": "ubuntu20.04",
Expand All @@ -32,9 +27,9 @@
},
{
"arch": "arm64",
"target": "ubuntu24.04",
"target": "ubuntu22.04",
"type": "deb",
"platform": "noble"
"platform": "jammy"
}
]
}

0 comments on commit 3a1043a

Please sign in to comment.