Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI cleanup #3

Open
LauraConnolly opened this issue Sep 19, 2022 · 2 comments
Open

GUI cleanup #3

LauraConnolly opened this issue Sep 19, 2022 · 2 comments

Comments

@LauraConnolly
Copy link
Collaborator

No description provided.

@LauraConnolly
Copy link
Collaborator Author

LauraConnolly commented Sep 19, 2022 •
edited by simonleonard
Loading

  • Remove .ui file? - code everything manually
  • Can rqt_gui elements be replicated in 3D Slicer? The can be used for service calls/publishing action/topics etc. Maybe these use .ui files that can be directly used in 3D slicer.
  • To take this one step further, can the rqt packages be used directly in Slicer. For example, the rqt_service_caller package has a resource .ui file with a specific layout. Can this be used in Slicer?

LauraConnolly added a commit that referenced this issue Nov 18, 2022
@LauraConnolly
Re #3: Updated the widget to use the .ui file only and not widgets th…
fc638ad 
…at are dynamically created.
LauraConnolly added a commit that referenced this issue Nov 23, 2022
@LauraConnolly
Re #3: Update ui - got rid of the topic and file option for visualiza…
273ac0b 
…tion. Changed behaviour from pressing enter on robot_description to a button that says "Load visualization". Added table for the subscribers - fit size of QWidget better. If you press the numMessages cell, the message pops up.
@adeguet1
Copy link
Collaborator

Based on preview conversations:

  • We should keep .ui approach as it is standard in the Slicer community
  • rqt is still something to investigate though it seems it is mostly a Python based library - this needs to be investigated further

Current GUI assumes there's only one ROS 2 node in the module but we now support multiple ones. We need to make some decisions re. how many nodes/tfbuffers should be added by default to the module's logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adeguet1 @LauraConnolly