-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add loading message to mail and contacts list #9027
Conversation
f999836
to
cf267f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works, thank you very much!
(@alecpl Just for clarity: I'm reviewing things but am currently not merging until you've had a chance to add your thoughts or we a grooved into a new workflow.) |
@alecpl Please have a look at this and provide feedback, or let us know that you're fine with us proceeding without your involvement. |
@alecpl Please respond in the open thread of this PR. (I'll take over and decide on my own after one more week of silence.) |
/remind me to merge this in one week |
@pabzm set a reminder for 12/9/2024 |
95b5492
to
9530fce
Compare
i have simplified the change. i think the important thing is the "list is empty" message does not display while the loading or searching actions are running |
👋 @pabzm, merge this |
@johndoh Thank you for reducing your change to a state that's agreeable to all! Could you fix the message of the first commit, please? (Contains a backslash instead of a quotation mark) |
@pabzm fixed, sorry I didn't notice that before and thanks for the changelog text |
@johndoh I allowed myself to resolve the conflict, since it was trivial and was caused by the Changelog line I wrote. Thanks again for this contribution! |
I'd prefer PRs to be squashed on merge. |
for #9006
adds support for 2 additional labels into the Elastic skindata-label-msg-loading
anddata-label-msg-empty
on list objects and uses those in the mail and addressbook templates to display a loading message in the list while the request is running.this does not break any, BC.data-label-msg
is still supported for simpler listsmakes the "this list is empty" message only show after loading/searching is complete, when changing mailboxes or until the loading/searching action is complete nothing is shown.