Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add loading message to mail and contacts list #9027

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

johndoh
Copy link
Contributor

@johndoh johndoh commented Jun 4, 2023

for #9006

adds support for 2 additional labels into the Elastic skin data-label-msg-loading and data-label-msg-empty on list objects and uses those in the mail and addressbook templates to display a loading message in the list while the request is running.

this does not break any, BC. data-label-msg is still supported for simpler lists

makes the "this list is empty" message only show after loading/searching is complete, when changing mailboxes or until the loading/searching action is complete nothing is shown.

Copy link
Member

@pabzm pabzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works, thank you very much!

@pabzm
Copy link
Member

pabzm commented May 7, 2024

(@alecpl Just for clarity: I'm reviewing things but am currently not merging until you've had a chance to add your thoughts or we a grooved into a new workflow.)

@pabzm
Copy link
Member

pabzm commented May 29, 2024

@alecpl Please have a look at this and provide feedback, or let us know that you're fine with us proceeding without your involvement.

skins/elastic/ui.js Outdated Show resolved Hide resolved
skins/elastic/ui.js Outdated Show resolved Hide resolved
skins/elastic/ui.js Outdated Show resolved Hide resolved
Copy link

@pabzm, @alecpl
🛎️ This PR has had no activity in two weeks.

@pabzm
Copy link
Member

pabzm commented Dec 2, 2024

@alecpl Please respond in the open thread of this PR. (I'll take over and decide on my own after one more week of silence.)

@pabzm
Copy link
Member

pabzm commented Dec 2, 2024

/remind me to merge this in one week

Copy link

github-actions bot commented Dec 2, 2024

@pabzm set a reminder for 12/9/2024

@johndoh johndoh force-pushed the list-loading branch 2 times, most recently from 95b5492 to 9530fce Compare December 4, 2024 16:53
@johndoh
Copy link
Contributor Author

johndoh commented Dec 4, 2024

i have simplified the change. i think the important thing is the "list is empty" message does not display while the loading or searching actions are running

Copy link

github-actions bot commented Dec 9, 2024

👋 @pabzm, merge this

@pabzm
Copy link
Member

pabzm commented Jan 3, 2025

@johndoh Thank you for reducing your change to a state that's agreeable to all!

Could you fix the message of the first commit, please? (Contains a backslash instead of a quotation mark)

@johndoh
Copy link
Contributor Author

johndoh commented Jan 3, 2025

@pabzm fixed, sorry I didn't notice that before and thanks for the changelog text

@pabzm pabzm merged commit 5844fb6 into roundcube:master Jan 3, 2025
17 checks passed
@pabzm
Copy link
Member

pabzm commented Jan 3, 2025

@johndoh I allowed myself to resolve the conflict, since it was trivial and was caused by the Changelog line I wrote.

Thanks again for this contribution!

@alecpl
Copy link
Member

alecpl commented Jan 8, 2025

I'd prefer PRs to be squashed on merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants