Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5051 by always showing inline attachments in list of attachments #9150

Closed
wants to merge 1 commit into from
Closed

Fix #5051 by always showing inline attachments in list of attachments #9150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions program/lib/Roundcube/rcube_message.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,6 +939,13 @@ private function parse_structure($structure, $recursive = false)
&& (!empty($mail_part->content_id) || !empty($mail_part->content_location))
) {
$this->add_part($mail_part, 'inline');

// Always show inline attachements in the list of attachments,
// as sometimes the attachment has a content-id but is not referred to in
// the HTML. Also if you switch to plaintext you won't be able to
// see the attachments. #5051
// https://github.com/roundcube/roundcubemail/issues/5051
$this->add_part($mail_part, 'attachment');
}

// Any non-inline attachment
Expand Down