feat: Add over-fetch for small gaps on backfilling
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandodeluret
commented
Feb 20, 2025
| @@ -9,21 +9,36 @@ use tokio::sync::mpsc::Sender; | |||
|
|
|||
| const GET_SIGNATURES_FOR_ADDRESS_LIMIT: usize = 1000; | |||
|
|
|||
| /// Below this limit, the gap will be processed using `GAP_LIMIT_RPC` as limit in the RPC call | |||
| const GAP_LIMIT: i64 = 10; | |||
There was a problem hiding this comment.
Should this be part of OverfetchArgs? For now it's set as a const to can be used inside impl TryFrom<TreeGapModel> for TreeGapFill
kespinola
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add overfetch to fix the issue where small gaps are not filled in the backfill process due to empty
get_signatures_for_addressRPC responses