Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System-upgrade, offline, and --offline tests #1475

Conversation

evan-goode
Copy link
Member

Add tests for the system-upgrade and offline commands and the --offline argument.

The system-upgrade tests are adapted from DNF 4, but moved out of dnf-behave-tests/dnf/plugins-core since system-upgrade is now a regular command and not a plugin.

@pep8speaks
Copy link

pep8speaks commented Mar 20, 2024

Hello @evan-goode! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-25 19:07:56 UTC

@evan-goode evan-goode force-pushed the evan-goode/offline-transactions branch from d858419 to 346cfa6 Compare March 20, 2024 19:39
@jan-kolarik jan-kolarik self-assigned this Mar 21, 2024
@evan-goode
Copy link
Member Author

Since this PR was still open, I added the tests for offline-distrosync and offline-upgrade here. So this patch now requires rpm-software-management/dnf5#1344.

@m-blaha
Copy link
Member

m-blaha commented Mar 27, 2024

/packit test rpm-software-management/dnf5#1344

@jan-kolarik jan-kolarik removed their assignment Mar 27, 2024
@m-blaha m-blaha self-assigned this Mar 27, 2024
@m-blaha
Copy link
Member

m-blaha commented Mar 28, 2024

/packit test rpm-software-management/dnf5#1344

@m-blaha m-blaha merged commit 6824b38 into rpm-software-management:main Mar 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants