Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releasever_{major,minor} tests #1621

Open
wants to merge 3 commits into
base: dnf-4-stack
Choose a base branch
from

Conversation

evan-goode
Copy link
Member

Backports #1359 to dnf-4-stack.

Adds a test for the new --releasever-major and --releasever-minor options.

Requires rpm-software-management/dnf#2198 and rpm-software-management/libdnf#1689.

For https://issues.redhat.com/browse/RHEL-68034.

Copy link
Contributor

@kontura kontura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good to also test that $releasever is not affected by setting major/minor.

Otherwise it looks good to me.

dnf-behave-tests/dnf/vars-releasever.feature Outdated Show resolved Hide resolved
@kontura
Copy link
Contributor

kontura commented Feb 5, 2025

I was looking into it a bit more and I realized it would probably be good to have a test where the minor/major values are overridden by package provides since that is the intended use-case.
It also uses a different code path in both libdnf/dnf.

@evan-goode evan-goode force-pushed the evan-goode/releasever-major-minor branch from 1ebe0bf to 7e94a04 Compare February 5, 2025 22:58
@evan-goode evan-goode force-pushed the evan-goode/releasever-major-minor branch from 7e94a04 to 75096bf Compare February 5, 2025 23:00
@evan-goode
Copy link
Member Author

I think it would be good to also test that $releasever is not affected by setting major/minor.

I was looking into it a bit more and I realized it would probably be good to have a test where the minor/major values are overridden by package provides since that is the intended use-case.

Both done, good suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants