needs-restarting: "Regular files" are often on 00:xx devices #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs-restarting currently checks the major:minor device of each mmapped file and ignores files from devices with major version 0, considering them "not regular files". According to the kernel docs [1], a major version of 0 is for "unnamed devices, e.g. non-device mounts". But ignoring files on 00:xx devices seems to not be a valid strategy. From my testing, in containers and in virtual machines especially, "regular files" managed by DNF are often on these devices. For example: ``` docker run -it --rm fedora:40 stat /usr/bin/sleep File: /usr/bin/sleep Size: 36864 Blocks: 72 IO Block: 4096 regular file Device: 0,100 Inode: 2403790 Links: 1 ... ``` This patch removes this filter so that we just check that a file has a corresponding file path. There are files that have (something that looks like) a file path but are not "regular files", for example: 7283/maps:7f7f3f0d2000-7f7f3f0e0000 rw-s 00000000 00:01 7224 /memfd:mozilla-ipc (deleted) We should be able to ignore these since they would not be in the RPM database anyway. [1] https://www.kernel.org/doc/Documentation/admin-guide/devices.txt
We can no longer detect that block devices like /dev/dri/card0 are not "regular files", since they have device IDs matching 00:xx, just like other legitimate files on some systems. This should be fine since no package should provide a file like /dev/dri/card0. Instead, we add a test that smap entries like ``` 556d60d52000-556d60e1c000 rw-p 00000000 00:00 0 [heap] ``` are not treated as regular files (since the file path doesn't contain a /).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs-restarting currently checks the major:minor device of each mmapped file and ignores files from devices with major version 0, considering them "not regular files". According to the kernel docs [1], a major version of 0 is for "unnamed devices, e.g. non-device mounts".
But ignoring files on 00:xx devices seems to not be a valid strategy. From my testing, in containers and in virtual machines especially, "regular files" managed by DNF are often on these devices. For example:
This patch removes this filter so that we just check that a file has a corresponding file path. There are files that have (something that looks like) a file path but are not "regular files", for example:
We should be able to ignore these since they would not be in the RPM database anyway.
[1] https://www.kernel.org/doc/Documentation/admin-guide/devices.txt