needs-restarting: Get boot time from systemd UnitsLoadStartTimestamp #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves https://issues.redhat.com/browse/RHEL-35577. Get the boot time from UnitsLoadStartTimestamp if systemd is available, but make sure to use the kernel boot time for calculating process start times using data from procfs. The previous attempt [1] at this failed to do so and introduced a regression [2]. Also, get the kernel boot time from the btime field of /proc/stat instead of calculating it from /proc/uptime, to be consistent with what procps-ng does. [1] rpm-software-management#527 [2] https://issues.redhat.com/browse/RHEL-39775
|
This commit equals to a commit from master branch which is good. But I believe we should readd UnitsLoadStartTimestamp entry to doc/needs_restarting.rst which we originally added in a0ac871, reverted with the code in commit f84b7e0 and forgot to readd in the #560 pull request for master branch. The lost documentation was: just above Could you please create a pull request against master and then add the commit to this rhel-10.0 pull request? |
|
Done, good catch. Here is the PR against master: #577. |
ppisar
merged commit 54b9f83
into
rpm-software-management:rhel-10.0
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #560 to RHEL 10.0.
Resolves: https://issues.redhat.com/browse/RHEL-35577