Additional features for config-manager #1128
Conversation
|
I am also wondering if the messages should be only written to logs or if there also shouldn't be a warning on stderr. |
|
I unlinked the issue #1011 , so that it's not closed upon merging this, because it wouldn't be fully resolved. We could either split the issue and link the newly created one or leave it as it is and then manually mark the individual items as resolved. |
| bool changed = false; | ||
| parser.read(repos_override_file_path); | ||
| if (!in_repos_opts_to_remove.empty()) { | ||
| const auto & repos_override_file_path = get_config_manager_repos_override_file_path(config); |
There was a problem hiding this comment.
This is not a problem of this PR, but I encountered this:
When I run dnf5 config-manager unsetopt fedora.gpgcheck (or any other option), there is no output, but nothing gets changed. Only when I finally looked at logs, I noticed there is config-manager: Request to remove repository option but config file not found: /etc/dnf/repos.override.d/99-config_manager.repo.
Shouldn't this file get created if it doesn't exist yet? Or am I missing something?
Moreover, this makes me think even more that the warnings should get also on the stderr, because it took me some time to figure out why nothing is happening.
There was a problem hiding this comment.
Shouldn't this file get created if it doesn't exist yet?
No. The file contains overrides of repository configuration. A non-existent file has the same meaning as an empty file - no overrides are defined.
There was a problem hiding this comment.
Ah, right. It doesn't make sense to create the file for unsetting the options. I was confused only because I initially expected the original repo file to be modified and seemingly nothing happened when I run the unsetopt command. But now I see it only works over the overrides and the error message makes that clear.
|
I wanted to unify logging to the logger and to the terminal. It is not yet implemented. So I will modify this PR to directly print the warning to stderr. |
I relinked it again as I created separate issues for the remaining tasks and mentioned them in the original issue. |
jrohel
force-pushed
the
dnf5/config_manager2
branch
from
d092722 to
1cbe4ca
Compare
jrohel
force-pushed
the
dnf5/config_manager2
branch
from
1cbe4ca to
3d2e4c6
Compare
e3deda9
|
Translation-related doubt: "repository" and "main" in the warnings below should be kept as in English (e.g. are they keywords in the code or command-line option), or they can be translated?
|
It solves tasks in the #1011 issue except for documentation and does not replace crc32 with library functions.
Requires: rpm-software-management/ci-dnf-stack#1429 adjustment of CI tests.
Closes: #1011 .