Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNF5] --enable-plugin and --disable-pluin: no match found message #1432

Conversation

jrohel
Copy link
Contributor

@jrohel jrohel commented Apr 21, 2024

Print a warning if no libdnf plugin with a matching name is found.

Also moves Context::libdnf5_plugins_enablement to Impl and adds getters Context::get_libdnf_plugins_enablement(). I overlooked it when I created the Impl.

Closes #1431
Depends on issue #1429. PR #1430 needs to be merged first, then I'll rebase this PR.

@jrohel jrohel force-pushed the dnf5/enable_disable_plugin_args_msg branch 2 times, most recently from dc5cd0e to 46f6334 Compare April 23, 2024 09:44
And adds getters get_libdnf_plugins_enablement().
@jrohel jrohel force-pushed the dnf5/enable_disable_plugin_args_msg branch from 46f6334 to 7e9d593 Compare April 23, 2024 11:33
Print a warning if no libdnf plugin with a matching name is found.
@jrohel jrohel force-pushed the dnf5/enable_disable_plugin_args_msg branch from 7e9d593 to 0c265de Compare April 23, 2024 13:57
@jan-kolarik jan-kolarik self-assigned this Apr 24, 2024
@jan-kolarik
Copy link
Member

jan-kolarik commented Apr 24, 2024

CI tests need to be adjusted to this change. There are lot of errors like this:

No matches were found for the following plugin name patterns while enabling libdnf plugins: repoclosure
No matches were found for the following plugin name patterns while enabling libdnf plugins: builddep

I've added the fix for CI tests: rpm-software-management/ci-dnf-stack#1492.

@jan-kolarik
Copy link
Member

/packit test –identifier dnf5-tests

@jan-kolarik jan-kolarik added this pull request to the merge queue Apr 24, 2024
Merged via the queue into rpm-software-management:main with commit a016832 Apr 24, 2024
14 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--enable-plugin and --disable-plugin: Write a message if pattern does not match any plugin name
2 participants