repo_sack: Treat all repos with solv_repo created as loaded #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-mracek
reviewed
Apr 22, 2024
jan-kolarik
force-pushed
the
jkolarik/fix-cmdline-repo-includepkgs
branch
from
850dbdb to
9971aca
Compare
|
@j-mracek Thanks for pointing me to a different direction. I've simplifed the solution, hopefully it's better now. |
…75530) Fix the implementation of the `is_loaded()` flag, as it's used for initializing includes in the solver. This issue arose in the 5.2.0.0 branch. Before that, the check relied on whether the `solv_repo` was null. = changelog = msg: repo_sack: Treat all repos with solv_repo created as loaded type: bugfix resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2275530
jan-kolarik
force-pushed
the
jkolarik/fix-cmdline-repo-includepkgs
branch
from
9971aca to
76e9292
Compare
jan-kolarik
changed the title
|
I've modified the commit message to match the current implementation of the patch. |
|
LGTM. This solution also fixes the same problem for repository loaded from a test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the implementation of the
is_loaded()flag, as it's used for initializing includes in the solver.This issue arose in the 5.2.0.0 branch. Before that, the check relied on whether the
solv_repowas null.Test: rpm-software-management/ci-dnf-stack#1489.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2275530.