utils::format: Support for formatting localized messages (translation, localization of argument format) #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Returns the plural message id from the encoded message.
Supports localization including plural forms.
jrohel
force-pushed
the
bgettext_plural_id_and_format
branch
2 times, most recently
from
d9a8312 to
980730f
Compare
jan-kolarik
reviewed
Feb 4, 2025
A new class `utils::Locale` has been created. It contains C and CPP locale. A variant of `utils::format` has been created which adds the `utils::Locale` argument. This allows the user to specify a locale for formatting.
jrohel
force-pushed
the
bgettext_plural_id_and_format
branch
from
980730f to
c6331e5
Compare
jan-kolarik
approved these changes
Feb 5, 2025
Merged
via the queue into
rpm-software-management:main
with commit Feb 5, 2025
0f4c6ee
17 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New overloads of the
utils::formatmethod acceptBgettextMessageas a format string. They allow to specify whether we want to translate the format string and define thelocaleused.