Use actual repository ID in stored transactions #2061
Draft
+42
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
force-pushed
the
mblaha/system-upgrade-repos
branch
3 times, most recently
from
460a416 to
544667e
Compare
Previously, the `Package::get_package_path()` method worked correctly only for packages in repositories of type `Repo::Type::COMMANDLINE`. When an RPM file was added to a regular `Repo::Type::AVAILABLE` repository, its package path incorrectly pointed to the cache directory instead of the local RPM file. This fix ensures the correct path is used.
Currently, when replaying a stored transaction, all RPM files are
placed into a single `@stored_transaction` repository. The user can see
this artifitial repository when checking from which repositories the
installed packages came:
❯ dnf repoquery --installed --queryformat="%{full_nevra} %{from_repo}\n"
vlc-plugin-gstreamer-1:3.0.21-15.fc40.x86_64 @stored_transaction
This can be confusing, especially during a system upgrade, which also
uses stored transactions.
With this patch, local RPM files from stored transactions are
placed to the repository they originally came from:
❯ dnf repoquery --installed --queryformat="%{full_nevra} %{from_repo}\n"
vlc-plugin-gstreamer-1:3.0.21-15.fc40.x86_64 updates
Fixes: #1851
Use explicit std::vector<std::string> constructor instead of uniform initialization.
m-blaha
force-pushed
the
mblaha/system-upgrade-repos
branch
from
544667e to
36d5e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when replaying a stored transaction, all RPM files are placed into a single
@stored_transactionrepository. This can be confusing, especially during a system upgrade, which also uses stored transactions.With this patch, local RPM files from stored transactions are placed to the repository they originally came from.
Fixes: #1851