Create progress bar in script callback if one doesn't already exist #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally, the script start callback is called after package verification has been done, so there is an active progress bar (created in the verification stage), however package verification can be disabled. If verification is disabled, then the script start callback is the first callback used (to run pre-trans scripts), and there will be no active progress bar, leading to a crash. To handle the case of disabled verification, create a new progress bar in the script start callback for it to use in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally, the script start callback is called after package verification has been done, so there is an active progress bar (created in the verification stage), however package verification can be disabled. If verification is disabled, then the script start callback is the first callback used (to run pre-trans scripts), and there will be no active progress bar, leading to a crash.
To handle the case of disabled verification, create a new progress bar in the script start callback for it to use in the future.
Fixes #1949