Ensure tests/setup.sh is only ever run inside the test-image #3552
+17
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretending this can be meaningfully run outside the image is just that, pretense. When it also makes things more complicated for no benefit, it's just a bad idea. Drop it, and clarify the running environment in the comments.
The setup can do any number of dangerous things like nuking parts of your system, make sure nobody accidentally runs it by placing a flag file from make_install and checking on setup.sh.
dmnks
requested changes
Jan 31, 2025
| mkdir -p $DESTDIR/build | ||
| ln -sf ../data/SOURCES $DESTDIR/build/ | ||
| # Make sure nobody runs this accidentally outside the environment | ||
| if [ ! /.rpmtestsuite ]; then |
There was a problem hiding this comment.
Oops, this is missing an -f. Without it, the conditional is always false (i.e. the file isn't actually required to exist for the script to continue) 😅
It's funny because this is the kind of thing that you just don't want to test locally 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can do dangerous stuff, its better not to even pretend it can be run from outside the image. Add a safeguard and drop the pretense of $DESTDIR support. Makes it much nicer too.