Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions/upload-artifact from 3 to 4 #496

Merged
merged 7 commits into from
Dec 18, 2023
Merged

Bump actions/upload-artifact from 3 to 4 #496

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
45148b2
Bump actions/upload-artifact from 3 to 4
dependabot[bot] Dec 18, 2023
7ae62d1
Bump actions/download-artifact from 3 to 4
dependabot[bot] Dec 18, 2023
7499961
Merge branch 'dependabot/github_actions/actions/download-artifact-4' …
jmezach Dec 18, 2023
48dfe04
Attempt to fix workflow
jmezach Dec 18, 2023
de1ae02
Fix typo
jmezach Dec 18, 2023
836ce00
Download test package too
jmezach Dec 18, 2023
689c728
Fix publish job
jmezach Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 32 additions & 18 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ jobs:

# Upload SDK package
- name: upload SDK
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: nuget-packages
name: sdk-package
path: ./src/MSBuild.Sdk.SqlProj/bin/Release/

# Package TestProject
Expand All @@ -83,9 +83,9 @@ jobs:

# Upload TestProject package
- name: upload TestProject
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: nuget-packages
name: test-package
path: ./test/TestProject/bin/Release/

# Replace tokens
Expand All @@ -100,9 +100,9 @@ jobs:

# Upload templates package
- name: upload templates
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: nuget-packages
name: template-package
path: ./src/MSBuild.Sdk.SqlProj.Templates/bin/Release/

# Run tests in parallel
Expand Down Expand Up @@ -143,9 +143,16 @@ jobs:

# Download artifact
- name: download-artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: nuget-packages
name: sdk-package
path: test/TestProjectWithSDKRef/nuget-packages

# Download artifact
- name: download-artifact
uses: actions/download-artifact@v4
with:
name: test-package
path: test/TestProjectWithSDKRef/nuget-packages

# Restore packages
Expand All @@ -164,7 +171,7 @@ jobs:

# Upload binary log
- name: upload
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binary-log-${{ matrix.os }}-${{ matrix.dotnet }}-exact-version
path: ./msbuild.binlog
Expand All @@ -182,14 +189,14 @@ jobs:
# Upload dacpac
- name: upload
if: ${{ matrix.os == 'ubuntu-22.04' && matrix.dotnet == '6.0.x' }}
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: dacpac-package
path: ./test/TestProjectWithSDKRef/bin/Debug/netstandard2.0/

# Upload binary log
- name: upload
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binary-log-${{ matrix.os }}-${{ matrix.dotnet }}-floating-version
path: ./msbuild.binlog
Expand All @@ -215,7 +222,7 @@ jobs:
steps:
# Download artifacts
- name: download-artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: dacpac-package
path: ~/dacpac-package
Expand Down Expand Up @@ -271,11 +278,18 @@ jobs:
with:
fetch-depth: 0 # avoid shallow clone so nbgv can do its work.

# Download artifact
# Download SDK
- name: download-artifact
uses: actions/download-artifact@v4
with:
name: sdk-package
path: test/TestProjectWithSDKRef/nuget-packages

# Download test package
- name: download-artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: nuget-packages
name: test-package
path: test/TestProjectWithSDKRef/nuget-packages

# Setup .NET SDK
Expand Down Expand Up @@ -306,7 +320,7 @@ jobs:

# Upload binary log
- name: upload
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: binary-log-publish
path: ./msbuild.binlog
Expand All @@ -331,10 +345,10 @@ jobs:

# Download artifacts
- name: download-artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
id: download-nugetpackages
with:
name: nuget-packages
name: test-package
path: ~/nuget-packages

- name: Display structure of downloaded files
Expand Down