Add ability to treat rule violations as errors #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffrosenberg
approved these changes
Feb 29, 2024
|
@jmezach Time to consider a 2.7.0 release? 😄 |
|
Sounds like a plan :) |
|
@jmezach Just FYI, did manage to do some field testing, and a small update is coming soon based on that |
|
Looks like the publishing pipeline isn't working correctly right now, so I'll have to look into that anyway ;). |
|
@jmezach Should this not be downloading the sdk and template packages instead of the test package? - name: download-artifact
uses: actions/download-artifact@v4
id: download-nugetpackages
with:
name: test-package
path: ~/nuget-packages
|
|
Yeah, that makes more sense ;). |
|
Release 2.7.0 is out there and includes your latest fixes. |
|
@jmezach Wonderful! Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #522