Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quotes around rules list and fix temporal table rules issues #532

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

ErikEJ
Copy link
Collaborator

@ErikEJ ErikEJ commented Mar 7, 2024

fixes #531

Also updates the rules to avoid false positives due to temporal tables: ErikEJ/SqlServer.Rules@a2b6197

@ErikEJ ErikEJ requested review from jeffrosenberg and jmezach March 7, 2024 06:28
@ErikEJ ErikEJ changed the title Add quotes around rules list Add quotes around rules list and fix temporal table rules issues Mar 7, 2024
Copy link
Member

@jmezach jmezach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix :)

@ErikEJ ErikEJ merged commit d2a10ac into rr-wfm:master Mar 7, 2024
13 checks passed
jmezach pushed a commit that referenced this pull request Mar 11, 2024
* add quotes around rules list

fixes #531

* Update to latest rules that fixes support for temporal tables, see ErikEJ/SqlServer.Rules@a2b6197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with CodeAnalysisRules when using ";" (semicolon)
3 participants