Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add estimate fee controller and delete unused endpoints #266

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add estimate fee controller and delete unused endpoints #266

merged 1 commit into from
Nov 21, 2023

Conversation

ronaldsg20
Copy link
Member 

	I've defined a proxy endpoint for /estimatefee/{block} call
	on blockbook. Also I've removed the controllers, services and
	models relatd with the endpoints /balance /unusedaddress /tx-fee
	and /pegin-tx, they won't be used anymore.

alexjavabraz
alexjavabraz approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@alexjavabraz alexjavabraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lserra-iov lserra-iov mentioned this pull request Nov 21, 2023
Merged
Base automatically changed from feature/get-address-info-endpoint to remove-redis-data-integration November 21, 2023 18:11
@ronaldsg20
Add estimate fee controller and delete unused endpoints
9e495ac 
		I've defined a proxy endpoint for /estimatefee/{block} call
		on blockbook. Also I've removed the controllers, services and
		models relatd with the endpoints /balance /unusedaddress /tx-fee
		and /pegin-tx, they won't be used anymore.
@ronaldsg20 ronaldsg20 force-pushed the feature/tx-fee-tx-creation branch from 3db2547 to 9e495ac Compare November 21, 2023 18:15
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@ronaldsg20 ronaldsg20 merged commit 3b5a67c into remove-redis-data-integration Nov 21, 2023
@ronaldsg20 ronaldsg20 deleted the feature/tx-fee-tx-creation branch November 21, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjavabraz alexjavabraz alexjavabraz approved these changes

@lserra-iov lserra-iov lserra-iov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronaldsg20 @alexjavabraz @lserra-iov