Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verify_attestation.py to accept distinct versions for UI and Signer #197

Merged
merged 3 commits into from
Sep 6, 2024
Merged

Fix verify_attestation.py to accept distinct versions for UI and Signer #197

merged 3 commits into from
Sep 6, 2024

Conversation

italo-sampaio
Copy link
Collaborator

  • Version MINOR is now allowed to be distinct between UI and Signer
  • Script outputs the installed version of both apps

Example output after a simulated signer upgrade to 5.2:

########################################
### -> Verify UI and Signer attestations
########################################
Using 0490f5c9d15a0134bb019d2afd0bf297149738459706e7ac5be4abc350a1f818057224fce12ec9a65de18ec34d6e8c24db927835ea1692b14c32e9836a75dad609 as root authority
--------------------------------------------------------------------------------------------------------
UI verified with:
UD value: 474cc830bb9159299ca788a7527b561817ffa42f5d13f5429f14a95b0ee154f0
Derived public key (m/44'/0'/0'/0/0): 0332aba656b37e4e927806e1fe72323e1a7ca784fcc0eb9de2b1590f32f822b956
Authorized signer hash: 9f21e535d64ae9ab768fb2b6ab43e645c4d78a18318dca656de9c329f26098e9
Authorized signer iteration: 2
Installed UI hash: f060858f70c1832b2ac06c88fd741a4c8a098c974ad51122b2669d57c1f9d89c
Installed UI version: 5.1
--------------------------------------------------------------------------------------------------------
---------------------------------------------------------------------------------------
Signer verified with public keys:
m/44'/0'/0'/0/0:   0332aba656b37e4e927806e1fe72323e1a7ca784fcc0eb9de2b1590f32f822b956
m/44'/1'/0'/0/0:   03db12ee740f88bb412b66aaed99bd1908917d9321f6393643d1435c6b59f8ee4f
m/44'/1'/1'/0/0:   031867a30ec059b17d5901092b866d81fcf359fb528954c1ece903d1667a114a22
m/44'/1'/2'/0/0:   02078a43a98b19be5c4cacf2cc6ae2e2431de20561540ba40b344e8884ddc86816
m/44'/137'/0'/0/0: 028047542a7bc3007eed06e8e690d5447d89a5d394a351b189e33c40545afcbcd3
m/44'/137'/1'/0/0: 02bbf36ba664cfa81c659aceadc50c6b28462cb720b5dd3ec5afd8c8bd593ce5a8

Hash: db8fcfb3827812d17a87e645ac19469469e9f9626608cc33a5aa4d361d9dc3a8
Installed Signer hash: 9f21e535d64ae9ab768fb2b6ab43e645c4d78a18318dca656de9c329f26098e9
Installed Signer version: 5.2
---------------------------------------------------------------------------------------

@italo-sampaio
Fix verify_attestation.py to accept distinct versions for UI and Signer
fdea642 
- Version MINOR is now allowed to be distinct between UI and Signer
- Script outputs the installed version of both apps
@italo-sampaio
Changes after code review
f55c161 
- Using regex to validate UI and Signer headers
- Added unit tests for header validation functions
@italo-sampaio italo-sampaio force-pushed the bugfix/verify-attestation branch from ab51987 to f55c161 Compare September 5, 2024 15:37
@italo-sampaio
Changes after second round of code review
e023df6 
- Reduced code duplication by using a pre-compiled regular expression
amendelzon
amendelzon approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@amendelzon amendelzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the comments.

@italo-sampaio italo-sampaio merged commit d6dc8b6 into master Sep 6, 2024
6 checks passed
@italo-sampaio italo-sampaio deleted the bugfix/verify-attestation branch September 6, 2024 13:53
amendelzon added a commit that referenced this pull request Oct 22, 2024
@amendelzon
Incorporate latest master (d85258d) changes:
7012339 
- Fix verify_attestation.py to accept distinct versions for UI and Signer (#197)
- Version 5.2.0 release (#194)
- Removing compilation products from repository (#200)
@amendelzon amendelzon mentioned this pull request Oct 22, 2024
Closed
amendelzon added a commit that referenced this pull request Oct 22, 2024
@amendelzon
Incorporate latest master (d85258d) changes:
25b639d 
- Fix verify_attestation.py to accept distinct versions for UI and Signer (#197)
- Version 5.2.0 release (#194)
- Removing compilation products from repository (#200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amendelzon amendelzon amendelzon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@italo-sampaio @amendelzon