Max APDU buffer size checks #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
amendelzon
commented
Jan 22, 2025
amendelzon
commented
- Renaming empty buffer error to more generic invalid buffer error
- Added max buffer size checks on powHSM, Ledger UI bootloader and Ledger UI heartbeat main I/O logic
- Removed lower untrusted SGX & TCPSigner I/O layer disconnection on inconsistent request
- Added request buffer emptying after an inconsistent request to untrusted SGX & TCPSigner I/O layer
- Added new RawCommand test type to firmware test framework
- Added test cases for empty APDU and oversized APDU to firmware tests
- Added test cases for Ledger UI bootloader and Ledger UI heartbeat
- Renaming empty buffer error to more generic invalid buffer error - Added max buffer size checks on powHSM, Ledger UI bootloader and Ledger UI heartbeat main I/O logic - Removed lower untrusted SGX & TCPSigner I/O layer disconnection on inconsistent request - Added request buffer emptying after an inconsistent request to untrusted SGX & TCPSigner I/O layer - Added new RawCommand test type to firmware test framework - Added test cases for empty APDU and oversized APDU to firmware tests - Added test cases for Ledger UI bootloader and Ledger UI heartbeat
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| # Normal result expectation | ||
| if not is_nonempty_hex_string(self.expected): | ||
| self.expected = None |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class Warning test
| if not is_nonempty_hex_string(self.expected): | ||
| self.expected = None | ||
| else: | ||
| self.expected = bytes.fromhex(self.expected) |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class Warning test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.