Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed GH code scanning issues #293

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

amendelzon
Copy link
Collaborator

  • Pinned remaining actions/checkout by hash
  • Pinned dist/sgx Dockerfile base image by hash
  • Pinned firmware/test/package Dockerfile base image by hash
  • Pinned mware's docker cython-hidapi package by commit hash
  • Removed self.expected overwriting from RawCommand test command, updated usage
  • Using cls for class variable name in all class methods
  • Fixed unused import in certificate.py by explicitly exporting modules, removed exception from linter
  • Removed unwanted comma from attestation verification script's header regexp
  • Made string concatenation explicit in lists

- Pinned remaining actions/checkout by hash
- Pinned dist/sgx Dockerfile base image by hash
- Pinned firmware/test/package Dockerfile base image by hash
- Pinned mware's docker cython-hidapi package by commit hash
- Removed self.expected overwriting from RawCommand test command, updated usage
- Using cls for class variable name in all class methods
- Fixed unused import in certificate.py by explicitly exporting modules, removed exception from linter
- Removed unwanted comma from attestation verification script's header regexp
- Made string concatenation explicit in lists
Copy link

github-actions bot commented Feb 3, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

  • .github/workflows/run-tests.yml

Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amendelzon amendelzon merged commit db5546f into master Feb 3, 2025
8 checks passed
@amendelzon amendelzon deleted the fix/gh-code-scanning-issues branch February 3, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants