Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved bip32 and dependent libraries to SGX HAL #295

Merged
merged 9 commits into from
Feb 4, 2025
Merged

Moved bip32 and dependent libraries to SGX HAL #295

merged 9 commits into from
Feb 4, 2025

Conversation

amendelzon
Copy link
Collaborator

  • Moved bip32, hmac_sha512 and endian libraries to SGX HAL
  • Moved corresponding unit tests to SGX HAL
  • Incidentally adding missing common.mk headers
  • Incidentally removing unused common.mk

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

italo-sampaio
italo-sampaio approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@italo-sampaio italo-sampaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amendelzon amendelzon merged commit 004d9b5 into master Feb 4, 2025
8 checks passed
@amendelzon amendelzon deleted the improvement/move-bip32-to-sgx branch February 4, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italo-sampaio italo-sampaio italo-sampaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amendelzon @italo-sampaio